[SPARK-16238] Metrics for generated method and class bytecode size#13934
Closed
ericl wants to merge 3 commits intoapache:masterfrom
Closed
[SPARK-16238] Metrics for generated method and class bytecode size#13934ericl wants to merge 3 commits intoapache:masterfrom
ericl wants to merge 3 commits intoapache:masterfrom
Conversation
|
Test build #61338 has finished for PR 13934 at commit
|
|
|
||
| /** | ||
| * Records the generated class and method bytecode sizes by inspecting janino private fields. | ||
| */ |
Contributor
There was a problem hiding this comment.
can we have a unit test for this?
It'd be useful once we upgrade Janino dependency.
Contributor
Author
There was a problem hiding this comment.
There is one below. It should fail if any of the janino internal apis change.
Contributor
|
LGTM - merging in master/2.0. |
asfgit
pushed a commit
that referenced
this pull request
Jun 29, 2016
## What changes were proposed in this pull request? This extends SPARK-15860 to include metrics for the actual bytecode size of janino-generated methods. They can be accessed in the same way as any other codahale metric, e.g. ``` scala> org.apache.spark.metrics.source.CodegenMetrics.METRIC_GENERATED_CLASS_BYTECODE_SIZE.getSnapshot().getValues() res7: Array[Long] = Array(532, 532, 532, 542, 1479, 2670, 3585, 3585) scala> org.apache.spark.metrics.source.CodegenMetrics.METRIC_GENERATED_METHOD_BYTECODE_SIZE.getSnapshot().getValues() res8: Array[Long] = Array(5, 5, 5, 5, 10, 10, 10, 10, 15, 15, 15, 38, 63, 79, 88, 94, 94, 94, 132, 132, 165, 165, 220, 220) ``` ## How was this patch tested? Small unit test, also verified manually that the performance impact is minimal (<10%). hvanhovell Author: Eric Liang <ekl@databricks.com> Closes #13934 from ericl/spark-16238. (cherry picked from commit 23c5865) Signed-off-by: Reynold Xin <rxin@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This extends SPARK-15860 to include metrics for the actual bytecode size of janino-generated methods. They can be accessed in the same way as any other codahale metric, e.g.
How was this patch tested?
Small unit test, also verified manually that the performance impact is minimal (<10%). @hvanhovell